Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update project profile remove Kristelle #7721

Merged
merged 1 commit into from
Nov 15, 2024
Merged

update project profile remove Kristelle #7721

merged 1 commit into from
Nov 15, 2024

Conversation

BlakePeters99
Copy link
Member

@BlakePeters99 BlakePeters99 commented Nov 15, 2024 •
edited
Loading

Fixes #7474

What changes did you make?

  • Removed Kristelle from the leadership variable
  • File changed: _projects/home-unite-us.md

Why did you make the changes (we will use this info to test)?

  • Updated so that Unite Us current team members is most up to date.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

UpdateProjectProfileHomeUnitedUSRemoveKristelleGumaruBEFORE

Visuals after changes are applied

UpdateProjectProfileHomeUnitedUSRemoveKristelleGumaruAfter

@github-actions GitHub Actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b BlakePeters99-update-project-profile-remove-kristelle-7474 gh-pages
git pull https://github.com/BlakePeters99/website.git update-project-profile-remove-kristelle-7474

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Nov 15, 2024
@codyyjxn codyyjxn self-requested a review November 15, 2024 03:02
@mamypoco mamypoco self-requested a review November 15, 2024 03:04
codyyjxn
codyyjxn approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@codyyjxn codyyjxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BlakePeters99 Thank you for taking on this issue.

  • The branch name is correct
  • The description is great as well.
  • The issue is linked correctly
  • before and after screenshots are great!

Some Suggestions

  • You can remove the extra bullet points
  • You can also edit the title to be a bit more clear of what files you changed.

Thank you for your contribution!

@mamypoco
Copy link
Member

Review ETA: 6 PM 11/15/2024
Availability: 9-3 PM M-F

@BlakePeters99 BlakePeters99 reopened this Nov 15, 2024
@BlakePeters99
Copy link
Member Author

Removed unnecessary bullet points and changed description to highlight which file was changed.

@trimakichan trimakichan requested review from trimakichan and removed request for trimakichan November 15, 2024 17:48
mamypoco
mamypoco approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@mamypoco mamypoco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job removing the requested person, @BlakePeters99!

@BlakePeters99 Thank you for helping this issue.

The branch name is correct
The description is great as well.
The issue is linked correctly
before and after screenshots are great!

Suggestions

I don't see CodeQL alert, so please check the section "I have checked this PR for CodeQL alerts and none were found."

Thank you for your contribution!

@mamypoco mamypoco mentioned this pull request Nov 15, 2024
Open
@BlakePeters99
Copy link
Member Author

Thanks @mamypoco and @codyyjxn for the review and suggestion! Updated my pr accordingly.

@roslynwythe roslynwythe merged commit cac44fe into hackforla:gh-pages Nov 15, 2024
15 checks passed
@trimakichan trimakichan removed their request for review November 16, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codyyjxn codyyjxn codyyjxn approved these changes

@mamypoco mamypoco mamypoco approved these changes

Assignees
No one assigned
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
P: HfLA Website: Project Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Project Profile: Home Unite US Remove Kristelle Gumaru
4 participants
@BlakePeters99 @mamypoco @codyyjxn @roslynwythe